Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more exact regex for Bitbucket strategy. #10068

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Use more exact regex for Bitbucket strategy. #10068

merged 4 commits into from
Dec 22, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Dec 19, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Previously, this also wrongfully matched https://bitbucket.org/blackosx/darwindumper/wiki/DD_AppCast.xml.

Extracted from #9529.

@BrewTestBot
Copy link
Member

Review period will end on 2020-12-22 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 19, 2020
samford
samford approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@samford samford left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already reviewed and discussed this as part of #9529 and I'm good with this approach. I'll update the other strategies to bring them in line with this refactoring after I've reviewed (and either merged or closed) #9519.

For what it's worth, bathyscaphe also runs into an undefined method sub!' for nil:NilClasserror in relation to thesuffix.sub!(/.t(?:ar..+|[a-z0-9]+)$/i, ".t")call, assuffixisnil` in this case. This PR addresses this issue as well.

I pushed a commit to bring URL_MATCH_REGEX in line with the more explicit regexes we're using in #9519. Namely, I added the protocol as an anchor at the start of the regex (https?://). [I also modified the regex to have the forward slashes at the start of lines, to align the style with multiline regexes in some other strategies.]

As part of reviewing #9519, I'm working on bringing the other strategies in line with the Bitbucket approach here.

@BrewTestBot
Copy link
Member

Review period ended.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 22, 2020
@reitermarkus reitermarkus merged commit 53ef74f into Homebrew:master Dec 22, 2020
@reitermarkus reitermarkus deleted the bitbucket-strategy branch December 22, 2020 17:21
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 22, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samford samford samford approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @BrewTestBot @samford